Simon Bachstein
Simon Bachstein
I am not entirely sure what you are suggesting: Are you saying the actual behavior is according to spec or are you saying the behavior that I am expecting is...
~~This issue is still present in the most recent version (2.6.1).~~ I have to correct myself: With 2.6.1 the token is shown after a description is given.
Has there been an effort to introduce the root path parameter, already?
I will give it a go then and will come up with a PR soon.
I have read the CLA Document and I hereby sign the CLA
> The client needs to be updated, otherwise it'll have the wrong url. > > e.g. > > https://github.com/Arize-ai/phoenix/blob/5e8bc3dad2036b2febb1d343103d331723413a72/src/phoenix/session/client.py#L244 The client provides the option to take the base path from...
Very good catch, thank you for the hint. I adjusted all usages of `urljoin` to avoid the absolute paths.
@RogerHYang Thank you for the hint again, that was kind of unexpected behavior for me, good to know!
To me that is expected behavior. If the application is mounted at a root path with prefix by a proxy then the proxy would also make sure to rewrite the...
Thank you for the thorough review!