Sayeed M Hussain
Sayeed M Hussain
@ankurkejriwal Doesn't work. Already tried.
@klesh Tried again and found it works when we give a trailiing slash after health/. thanks! It will be better to remove the trailing slash from nginx as trailing slashes...
@klesh It's hard to tell if it will be break existing consumers or not as that depends on how their respective libraries handle a trailing slash (strictly or loosely). Personally...
@klesh Sure. Simplest and clearest would be adding another block for `/health` like here https://github.com/apache/incubator-devlake/pull/5745/files#diff-0bade717fcb1c175b0b0a027ab7edbe026b60684ea2c5a5115e2742d1de07449R40. Better than adding regex to the existing path which increases complexity for reader. If this...
@klesh https://github.com/apache/incubator-devlake/pull/7009. Once this gets incorporated in a release and the helm chart repo accommodates that release, will raise the PR there.
@klesh Do you mean cherry-pick this commit to release-v0.21 branch?
@klesh, @Startrekzky PR to release branch https://github.com/apache/incubator-devlake/pull/7038
Closing this defect now as the changes are merged to main and release branch cc: @klesh , @Startrekzky.
@klesh was planning to add this change in the helm repo but looks like someone did it already 2 weeks back. All good. https://github.com/apache/incubator-devlake-helm-chart/blob/61cd2eea31e9daacd43ca29766fe70dbd003d3d4/charts/devlake/values.yaml#L273
thanks for the analysis @d4x1. For now, we are able to work around this issue by fixing our mysql queries. But in general, I think it would be good to...