Sayandip Dutta
Sayandip Dutta
Would be happy to add a PR, if the above proposal sounds reasonable.
Sure, I will add one today.
@skirpichev Is `initial=None` safe for backward compatibility? Does this mean `reduce(Callable[[None, T], None], Iterable[T], None)` will behave differently in 3.13 and 3.14?
@skirpichev should the default be specified at all? I think `reduce(function, iterable, /, initial)` is closer representation of internal working than `reduce(function, iterable, /, initial=None)`. Or is there some sort...
Yes, I just pushed the changes, i.e. made it unsupported instead of no_signature. I was trying to look for docs regarding this, is there any? Like what makes a signature...
Thanks a lot @skirpichev! It seems all I have to do is wait for your PR to be merged and then merge main into my PR. Will do so.
I have made the requested changes; please review again
Checked against debug build. Followed script from https://github.com/python/cpython/pull/125917#issuecomment-2434813259 |call| Main branch | This branch | |---| ------------- | ------------- | |reduce(f, lst)| 3.59 us +- 0.13 us | 3.51 us...
`polars` repo says this about the underlying function [1](https://github.com/pola-rs/polars/blob/b2550a092e34aa40f8786f45ff67cab96c93695d/py-polars/polars/io/pyarrow_dataset/functions.py#L13-L25): ```python @unstable() def scan_pyarrow_dataset( source: pa.dataset.Dataset, *, allow_pyarrow_filter: bool = True, batch_size: int | None = None, ) -> LazyFrame: """...
I have not updated the docs, or all the places this appears in doctests and tests. Will do so after feedback/review.