Oleksii Savchuk comments

Results 6 comments of


                                            Oleksii Savchuk

theme-product-form onSubmit option ID setting conflicts with buy now button

@t-kelly @n-dawson Many apps add additinal event listeners to id input to include own logic, so it is better to require id input to be present during init. Also it...

Add custom selectors option. Fix theme-product-form logic

@NoZiL @martinamarien Please, review this changes

theme-product-form doesn't work with some third party apps

@t-kelly @statementtom ReCharge add custom select and remove name="id" from original select to own one. When _setIdInputValue try to set variant value to new element variant value does not exist...

Fix Guzzle error processing with http_errors=true

@GrahamCampbell Done

Fix Guzzle error processing with http_errors=true

@GrahamCampbell sorry, have not time for continue this pr. Can you help me with tests?

shopify cli dev is so slowly

Shopify CLI is using v3 of chokidar. Looks like a chokidar v4 resolves performance issues for Windows: https://www.npmjs.com/package/chokidar