Sarah Yurick
Sarah Yurick
Fixes example in #320 ``` df = pd.DataFrame({'id': [0, 1, 2], 'name': ['a', 'b', 'c'], 'val': [0, 1, 2]}) c.create_table('test', df) c.sql(""" select name, val, id from test a where...
Looks like this was resolved on the DataFusion side with https://github.com/apache/arrow-datafusion/pull/3287 !
Not sure if someone is working on this right now, but I don't see a `ValueError` anymore. It looks like `COUNT(DISTINCT x)` incorrectly produces the exact same output as `COUNT(x)`,...
I am able to reproduce the same error with Jupyter Lab, but `c.ipython_magic()` already works with a regular Jupyter Notebook. One user from [Stack Overflow](https://stackoverflow.com/questions/54442858/javascript-output-is-disabled-in-jupyterlab) suggested doing Help -> Launch...
Issue #532 is also about `test_agg_count`, so both can be closed with this fix.
I'm not quite sure why `test_fsql` is consistently failing at https://github.com/dask-contrib/dask-sql/blob/main/tests/integration/test_fugue.py#L67
> Also looking through the postgresql [docs](https://www.postgresql.org/docs/15/functions-datetime.html) the integer version of this method doesn't accept a `format` argument. Do you think it's possible to update the parser to handle this?...
Let me know if you think any tests from Dask-ML's `tests/test_parallel_post_fit.py` or from https://github.com/dask/dask-ml/pull/912 should be added.
Can we close this issue since we've eliminated all Dask-ML dependencies?
I think this would also close https://github.com/dask-contrib/dask-sql/issues/130