Sarabveer Singh

Results 113 comments of Sarabveer Singh

This is required by GurbaniNow/api for the Node.js re-write.

Fixed in https://github.com/GurbaniNow/api/commit/c2abac5125d8a165ef5978d2e99685735d40a4ea https://github.com/GurbaniNow/api/commit/c12355ee48031e800c3b772b4f929b020c17c1f8

How would performance be variable? The structure for each line returned would be the same, limiting search results is for performance.

@Harjot1Singh I think that would work, but do we have queries inside queries? Never looked at the raw query generated from the API.

Sri Dasam Granth Shiromani Steek (Vol. 6), Page 112 (124 in PDF) ![image](https://user-images.githubusercontent.com/4297171/66839787-fa687b80-ef34-11e9-920a-3d5d114b5631.png)

Not sure about the average user, but this is required for v5. Otherwise subsections are useless as many share the same name.

@saihaj Instead of having something like `"subsection": "Jap",` in the json, it would be an immutable id, like `"subsection": "HJ6",` You can see all the current defined subsections here in...

@Harjot1Singh subsection names arent unique, which is why this issue was opened.

Section doesn't need immutable IDs as up to this point, they are unique. However, within a section, there can be multiple subsections sharing the same name. So immutable IDs for...

![image](https://user-images.githubusercontent.com/4297171/85802373-d2abf300-b712-11ea-8163-a0d8b09da2e7.png) @bhajneet Similar to #1757, but in this case, it is a typo.