Santi Leira comments

Results 23 comments of


                                            Santi Leira

Error: Cannot find module 'request'

i had the same issue, thanks for the solution @goodevilgenius

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

> Can you please run [benchstat](https://pkg.go.dev/golang.org/x/perf/cmd/benchstat) and add the result to the description to see what is the performance overhead? @pellared done, as far as I understand, there is no...

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

@pellared could you review this PR? Thanks in advance.

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

@dmathieu could you help me to move this PR forward? I created it last week.

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

@dmathieu I did some changes based on @pellared feedback, could you review the PR again? Thanks

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

> Please fix the lint errors (you can ignore the errors as the returned error is always nil). Sure

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

@dmathieu could you approve it again?

Fix issue when percent encoded octet sequences don't match the UTF-8 encoding schema

@pellared I will update it and merge it.

Baggage propagation - replace invalid percent-encoded octet sequnces with replacement char

hey @lachmatt what is the expected behavior? that code should return 7 and true, right? ``` fmt.Println(len(val)) fmt.Println(utf8.ValidString(val)) ```

Baggage propagation - replace invalid percent-encoded octet sequnces with replacement char

@pellared I could fix it, could you assign me this issue?