Sam Umbach comments

Results 25 comments of


                                            Sam Umbach

markdown-styles missing from `package.json`

Related: I added the following at the top of `Makefile` to get the build to work without modifying specifying `PATH` on the command line: ``` SHELL:=/bin/bash PATH:=node_modules/.bin:$(PATH) ```

Consider to include readarray and map key value arrays

:+1: @jmorcar `readarray` (aka, `mapfile`) was added in Bash 4, so I would present this as an alternative to traditional `read` tricks when Bourne sh or POSIX compatibility isn't a...

Note to prefer $() over ``, and update single example to conform

Nice catch, @matthewcurry 😃 I support this 💯 . We might want to swap the order of ``` `` ``` and `$()` in the prose and sample code block, too,...

Use POSIX-compliant string comparison operator

Good eyes, @vtronko 👀 🦅 💯

IFS is confusing...

@bucaran Yes, definitely :confounded: The _idea_ of IFS and word-splitting isn't too complicated or difficult to understand, but the particulars are very tricky. I opened this issue to try to...

Fix minor inconsistency

Makes sense to me @inlikealion. If that is the case, I think this would be easier to understand with the "room" analogy: ``` In your base stylesheet: /** * Extend...

Same `HttpClient` instance should be used when following redirects

Thanks for the quick reply, @ptaoussanis ! I thought of another potential case (changing the var root binding), so I want to add a test case for this and then...

Allow keywords with intervening :

@trptcolin Is this the same issue described on the mailing list in May 2013? [Bug in reader or repl? reading keyword :#abc](https://groups.google.com/forum/#!topic/clojure/lK7juHxsPCc)

Limit CLJ_WATSON_* env vars to known properties?

I doubt there's any security concern here, as anyone who could inject a `CLJ_WATSON_SOME_OTHER_PROPERTY=...` env var into a process could presumably inject a `-Dsome.other.property=...` JVM argument instead. There _might_ be...