Sam Splunks

Results 18 comments of Sam Splunks

I had the same thought when I first tried helpdesk although I understand @Benbb96 for the timeline.

The time_spent displayed in template doesn't work for timedeltas over 24 hours. I will fix that also.

if HELPDESK_ENABLE_TIME_SPENT_ON_TICKET is True, there are two options if automation is enabled: - the user doesn't provide time_spent and it is automatically calculated - the user provides time_spent and it...

**format_time_spent** is defined in lib.py and models.py, both are used.

Technically, the feature set is complete but there are some details to take care of: - ~~remove duplicate **format_time_spent** definition~~ - show time_spent at 0 in ticket template when time_spent...

This PR is ready for review, I hope you will find the feature interesting.

Thank you @Benbb96 for your review. Yes, I had tests on my mind, especially for time calculations verification. I don't have much time but I will see if I can...

@Benbb96 I think I addressed all the great remarks you have made.

Ticket queue change does not seem to be considered part of a follow-up, that makes the HELPDESK_FOLLOWUP_TIME_SPENT_EXCLUDE_QUEUES work only the first time time_spent is calculated. Is the change saved somewhere?