Sammy Gill

Results 7 comments of Sammy Gill

Implement last baseline for block elements in a flex container.

Updated RenderBlockFlow::lastLineBaseline so that the call to modern layout lastLinePhysicalBaseline was guarded by an if instead of an assert. Now we should fall back to legacy line layout the scenarios...

Implement last baseline for block elements in a flex container.

- [x] Once https://github.com/WebKit/WebKit/pull/5153 lands need to remove the code that was refactored out. 2 of the TestExpectations rely on that patch in order to pass

Implement last baseline for block elements in a flex container.

Rebaselined test expectations with the new tests imported from WPT

Include aspect-ratio when calculating inline min-content size and add min-content block computation

> There are quite a number of typos to fix (minimuim etc.). > > Overall progress looks great. However flex-aspect-ratio-026.html is not completely fixed. I worry a bit that improving/fixing...

Update align-items-baseline tests to use checkLayout

Hi @bfgeek! I was working on some baseline alignment bugs and ran into a scenario where a patch rendered the test correctly but we were still failing due to a...

Update align-items-baseline tests to use checkLayout

@bfgeek Just wanted to ping one more time in case you had any thoughts/opinions on the changes

Update align-items-baseline tests to use checkLayout

Thanks @dholbert! Yes, those line-heights discrepancies were unintentional and I have fixed them along with your other suggestions!