Basil Dubyk
Basil Dubyk
@solarissmoke @sasha0 I have slightly updated this PR. Please review when you will have a chance. Thanks!
> Also we need to think about the case when basket is disabled within the view, but called in the templates. Easiest approach I have in mind is to throw...
> 3. It looks like you've been able to decouple voucher and basket pretty well! I think we need to provide a data migration for the `Basket.vouchers field` to the...
Probably it is better to use `is_basket_enabled` (instead of `is_basket_disabled`) and "add basket" only where needed (instead of "remove basket" from where we do not need it - e.g. in...
@ozandogrultan Many thanks for your comments. I have updated this PR.
Hi, @iproha94. Thank you for your review. I will check your comments and make updates asap.
@ozandogrultan, @auvipy, @iproha94 please review the updated PR. Many thanks.
I think we can add the ability to set custom `InvoiceCreator` from settings as we did for custom invoice model. https://github.com/django-oscar/django-oscar-invoices/blob/e7c46763285df0dd1f9cdfc2c30e714e09865cdc/oscar_invoices/app_settings.py#L7 @sasha0 @specialunderwear WDYT?
```bash In [3]: preauthorization.debited_funds Out[3]: EUR 2495 In [4]: str(preauthorization.debited_funds) Out[4]: 'EUR 2,495.00' In [5]: vars(preauthorization.debited_funds) Out[5]: {'amount': Decimal('2495'), 'currency': 'EUR'} ``` But the correct number to show is `24.95`....