Sami Pflibsen-Jones
Sami Pflibsen-Jones
I am having trouble replicating the issue, but I have implemented an atexit handler for tearing down the server socket in #155. Could someone verify that this fixes the issue?
I don't see any commited code referenced in #91, only discussion; am I missing something?
As for calling `run()` multiple times, [that's handled before the atexit register happens](https://github.com/jonashaag/bjoern/blob/5f38de0d950aac91db7b39efbb01bb116eef83a7/bjoern.py#L86) (it would throw a RuntimeError).
I just reviewed the `atexit` docs and realized there's a problem with my fix. ``` The functions registered via this module are not called when the program is killed by...
Welp, I had my head in the code and missed your most recent comment, so the fixes have been implemented regardless haha.
Added basic ping tests and examples for Win10 and Ubuntu in #9. A good addition would be to add formatting placeholders in the ping examples, such as (example from Ubuntu):...
@JosephRedfern I added your name and GitHub handle to the contributors section at the top of `netcheck.py`. Let me know if you have a problem with that; I'll remove them...
@JosephRedfern Open source is about "us", not "me" :)
Confirmed working for German on Windows 10. Keep issue open while we confirm other languages, too.
Ooh excellent idea. I think I'll tackle this one next.