Sam Menza

Results 8 comments of Sam Menza

Hey @jason0x43 I created a PR to resolve this at #1117 however I'm unsure how to test to see if it worked. Where am I suppose to look for the...

@tomdye you mean change the invalid type on the widgets to only be `{ valid: boolean, message: string }` and not `{ valid: boolean, message: string } | true` that...

I think so, I'm also not sure why it's currently `{ valid: boolean, message: string } | true`, it seems to really complicate the logic for not alot of gain

I took at quick look at where this is used in the code base and it seems like 4 places would need to get updated: - `TextInput`'s valid - `TextArea`'s...

Should this extend to the example app as well? For instance should we have nested menu items? The top menu bar on the example app will get kinda long

I think this is a good idea honestly, the widgets could get out of control especially since we're adding in all the new specialized inputs. I like the `form/input` nesting...

Also experiencing this error, storybook version `7.0.9`, node version `v16.14.0`, yarn version `1.22.19`

Oh yea sure if there is already an MR out for it, go for it