sambaneko

Results 7 comments of sambaneko

It looks like a similar issue was already fixed and merged (#755), but the npm package is not up to date with those changes? Can the npm package be updated?

Alternatively, I tried switching to the npm package provided by pdeszynski in #786, and it is working properly for me with strict mode enabled.

@m21tomas I haven't thoroughly tested it myself, but since it has been submitted as an update for the react-tooltip package, it should support all of the same syntax and commands.

Alternatively, I tried short circuiting the getter if window isn't open: ``` function getWPixelSize(w: WebampWindow, doubled: boolean) { if (!w.open) { return {height: 0, width: 0} } ... ``` Doing...

I'd say this PR can be closed, but wanting to clarify that my original description of the issue is wrong. User passing a window with missing size is working fine;...

Sure - added those in! Wasn't sure what to do put for the "Since: " lines...

Updated but maybe still wrong; should the "since"s be omitted in favor of just "Unreleased"? Didn't see a missing line tho...?