Hao-Wen (Herman) Dong 董皓文

Results 34 comments of Hao-Wen (Herman) Dong 董皓文

Hi, track-conditional generation is only available in MuseGAN v1, which can be found in the folder `v1`. There is no plan to support track-conditional mode in the latest version in...

We follow `torchvision` to have root directory as an argument. I am not sure how much efforts need to make this works as expected. A super naive implementation is to...

Hi, track-conditional generation is only available in MuseGAN v1, which can be found in the folder `v1`. There is no plan to support track-conditional mode in the latest version in...

Added in 28afd97. The implementation of the REMI representation is different from what described in the paper though.

Hi @hyeshinchu, You need to read the MIDI file into a MusPy Music object first. ```python import muspy music = muspy.read("./unconditional_4.mid") print(muspy.pitch_range(music)) ``` Let me know if you have any...

I am not in favor of the idea of automatically creating the directory if it does not exist as typo can be quite common. For example, a typo like `a/x/c/d/e`...

> But `mkdir(parents=False, exist_ok=True)` prevents typos like a/x/c/d/e. To me, it's reasonable to require the _parent_ directory to exist, but not `root` itself, as it is a directory dedicated to...

> If the extraction process is interrupted, `.muspy.success` should not exist, right? And as far as I understand, you are already checking the archive checksum if it exists. That's right....

`datasets.utils.download_url` now has an `overwrite` argument, but it's actually quite tricky to add it to `datasets.utils.extract_archive`.

Checking the existence of `.muspy.success` for `download_and_extract` is not intuitive enough by its name. Perhaps what would be more handy is an argument like `make_sure_exists` or `download_and_extract="auto"` that automatically checks...