Fernando Saint-Jean

Results 15 comments of Fernando Saint-Jean

I'm kind of a fan of the RetryableException pattern. Not sure about IOException being retryable by default. But - if your ErrorDecoder gives back a RetryableException (or one that inherits...

to add: I've used a retryer before. I basically had a situation where we wanted to authenticate once, then use the authentication cookie for all subsequent requests (without authenticating every...

@hellboy81 can you try: There's one part in the exception generator that I'm not terribly proud of: ``` private Object resolveBody(Response response) { if (bodyType instanceof Class && ((Class) bodyType).isInstance(response))...

If you take a look at https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/SynchronousMethodHandler.java (notice it's a final class/etc) you'll see that at method `public Object invoke(Object[] argv)` (line 74 at the time of this note) there's...

No prob. I'm now confused as to what it was you were trying to achieve... It isn't clear to me. When do you want to retry and how?

(hit submit too soon...) The RetryDecoder is an error decoder (just like the annotation-error-decoder is one). Feign only lets you pick one. I'd argue rather than using the RetryDecoder, you'd...

Hey - I haven't really had that so there isn't the option right now. We can try to add it if it's necessary - wondering if we have to add...

Hey @chrisob55 - I'll take a look but I'll need to try to reproduce the issue. Do you by any chance have a zip of a sample of the issue...

Let me give it a try. Can you give me the exact spring dependencies so I can make sure we're on same versions/etc and I can try to debug? On...

Working on it. I need to re-encrypt/re-authorise so that the automated process can release and push to maven central/etc. Should be done soon.