sabri aziri

Results 11 comments of sabri aziri

I agree too, we definitely need pre-release.

This is essential for a framework, please have this consider.

@jagadeshanh In your case `request_types` is formArray right? If so, the issue known, is because currently `setValue` accepts only string not array or objects, can you submit PR for this?

I know there was an issue and I solved it with `toString()` but I don't remember what was the issue! However, change if you can make it work properly.

@ghiscoding I am also interested to bring this feature in but I don't have a much time these days. Let's start to discuss here, make a short plan and see...

@ghiscoding great tip for `getErrorKey('username')`, it will do the job for 3,4 and 5. I think it will be good if we do not include any third party library for...

One more thing to discuss and we will be good to go, params(dynamic text), `ngx-translate` uses something like: `{{ 'HELLO {{dynamicPart}}' | translate:param }}` where `param` is object of keys...

@mengi23 your expression has extra ')' and instead of it, use this one ```[^((http|ftp|https):\/\/)?([\w_-]+(?:(?:\.[\w_-]+)+)([\w.,@?^=%&:\/+#-]*[\w@?^=%&\/+#-])?$]```

Looks like a bug, unfortunately I am not able to test it, can you try pattern without this character: `|` and let me know if you are still seeing the...