Sabir Hassan

via Hubstaff User: Sabir Hassan Project: vscode-extension - https://app.hubstaff.com/projects/2310883 Date Range: 01/26/23 - 01/26/23 Work session total: 2:23:00 Billable: Yes Grand total: 2:23:00

via Hubstaff User: Sabir Hassan Project: SASjs cli - https://app.hubstaff.com/projects/2310875 Date Range: 01/24/23 - 01/26/23 Work session total: 10:33:40 Billable: Yes Grand total: 10:33:40

> Currently when using [adapter.login() ](https://adapter.sasjs.io/classes/reflection-717.reflection-180.sasjs.html#login), if the user is already logged in, we do not attempt a login. > > This behaviour is ok, however it is not transparent...

via Hubstaff User: Sabir Hassan Project: SASjs lint - https://app.hubstaff.com/projects/2310878 Date Range: 01/10/23 - 01/11/23 Work session total: 5:16:01 Billable: Yes Grand total: 5:16:01

via Hubstaff User: Sabir Hassan Project: SASjs lint - https://app.hubstaff.com/projects/2310878 Date Range: 01/09/23 - 01/10/23 Work session total: 9:19:59 Billable: Yes Grand total: 9:19:59

I started working on the same Nip44 encryption for Signers yesterday. Before starting I checked there was no PR. Now I just saw your PR. I completed the implementation earlier...

During some testing, I observed that [this](https://github.com/nostr-dev-kit/ndk/blob/master/ndk/src/signers/nip46/backend/index.ts#L105) statement always returns false. I provided a hex string and it returned false, which is logical as it's not an instance of the...

> @sabhas issues with instantiation of NDKNip46Signer would not be covered by this PR ... until I start messing around with implementing NIP44 encryption for NDKNip46Signer ... which I have...

@manimejia I agree that the issue I highlighted is not relevant to nip44 encryption. But you have already implemented nip44 encryption for 2 signer classes (nip07 and private-key signer). I...