Tyler A. Young

Results 25 comments of Tyler A. Young

Here are the results on Felt's codebase, running on my M1 MacBook Air. I've included our tests tagged `:slow`, which we normally only run in CI, since those are the...

This fixed a crash in -O3 builds for us when a `std::shared_ptr` was the expected type. I'm... really, really not sure why that is... it looks like maybe the implementation...

At this time, I don't have a professional use for Z and M coordinates, so I'm rather loathe to make big changes here without knowing the real-world use cases. If...

@jnylen If you'd like to submit a PR, that'd be awesome. I'm not sure what the expected behavior here would be—do we stick `nil` values in the multilinestring's `coordinates`, or...

Hi @iloveitaly! I just merged an overlapping PR (#169). I think it covers all the same things on the GitHub Actions side, but if you want to rebase off the...

I'm gonna go ahead and close this due to inactivity. Happy to take the changes in another PR, though. 👍

Sigh. Yeah, filtering these out was probably the wrong choice in #176—I knew at the time that the GeoJSON spec hinted that features with no geometry might be desired. I'll...

@carstenpiepel Thoughts on what the best way to handle this might be? My initial thought was a `%GeometryCollection{}` with an empty list of `geometries`, but the GeoJSON spec warns: >...

Thanks for the kind words! I agree it probably needs a name change. 😅 Parameterized tests is accurate, but it's both longer and harder to spell if we make that...