Sina M

Results 273 comments of Sina M

I faced the same issue [here](https://github.com/ethereumjs/ethereumjs-vm/pull/463). As @cdetrio pointed out, `BN.mont` is choosing r as a power of 2, which means the modulus should be odd and greater than 3...

Nitpick: please rename to `stateDiffTracer` Edit: also it was on my backlog to implement this tracer myself, thanks for opening the PR!

Also if #25430 is merged, then this can become an option in the `prestateTracer`. Something like `collectAfter: true`, which when falls returns the same result as now for backwards compatibility...

I implemented a different approach we roughly discussed with @fjl: the rpc handler will run the method in a goroutine now. It waits for that to finish OR the context...

Can you please re-compile with this patch and see if it still halts on start? @karalabe pointed out an issue in the legacy detection function: if there are no non-empty...

Posting the [graphql query](https://geth.ethereum.org/docs/rpc/graphql) to get this data for anyone who needs it until this API method goes through the process: ```graphql { block { number hash logsBloom transactions {...

@tursom sorry I somehow missed your comment. No you don't need to add anything graphql related to the PR. The graphql already supports what you want to do. You can...

But output and error are already returned as part of `callTracer`. If efficiency is a concern one option I can think of is to allow `callTracer` an option to process...

> The options is already in the codebase but I thought it might be complicated to have multiple types of options. To be clear I'm not asking you to do...

So, I have a patch which adds the revert reason to the call tracer: https://github.com/s1na/go-ethereum/tree/calltracer/revert. It builds on #25430 which adds a `onlyTopCall` option to call tracer. When this is...