s-kuberski

Results 20 comments of s-kuberski

Thanks a lot for anticipating this and for fixing the problems in the dependencies! I am fine with dropping python 3.8 in the future.

Hi Pia, thanks a lot for adding this feature, I think it will be quite useful. I'll take some time to test your implementation before I provide further feedback.

Hi, thanks for your explanation. I started these distributed comments but I'll try to condense everything to a single message now... Based on what I understand from our discussion, we...

Hi, sorry for the delay... > Just to be sure you meant to say correlation matrix? So you are happy with kwargs options corr_matrix and inv_chol_cov_matrix as they are now?...

Hi, we discussed a bit offline to be more efficient. As I understood, @PiaLJP will get back to implementing the changes that we discussed in the near future.

Thanks a lot for the last changes. From my side, this can be merged. If you are fine with this @fjosw, I'll go ahead.

Hi, thanks a lot for having this in mind and for your collection of suggestions. The easiest option would of course be to hope for someone to take care of...

Hi, I had looked at this in the past. Basically, in my opinion, it is a bug in the way the slicing is defined for the correlator and it could...

I am not sure. It is the question if you consider this fixing a bug or introducing a breaking change, but I think the semantic versioning would tell you not...

Hi, thanks for the suggestion! What was the bug in the existing implementation? The missing 'float()'? In general, I think that it is handy to have a wrapper that makes...