Krzysztof Rzymkowski

Results 30 comments of Krzysztof Rzymkowski

That's because you're writing to the output stream from several threads at once (using CompletableFuture). Fastexcel is not thread-safe.

Looks like a standard [floating point proglem](https://floating-point-gui.de/basic/)

You're right. I was too quick to dismiss it as floating point issue as fastexcel's API exposes BigDecimal not a double. I did check the code just now and BigDecimal...

The actual value in test.xlsx is `1.1000000000000001`: ``` 1.1000000000000001 ``` This test passes: ``` try (InputStream is = Issue92.class.getResourceAsStream("/test.xlsx"); ReadableWorkbook wb = new ReadableWorkbook(is)) { Sheet sheet = wb.getFirstSheet(); try...

I have added a test to ensures that streams returned by fastexcel do work properly when in parallel mode - https://github.com/dhatim/fastexcel/commit/f2bee0f28be2a206acf465e1920a5005ccdcff2f - and they do behave the same as in...

`File.toPath()` requires Android API [level 26](https://developer.android.com/reference/java/io/File.html#toPath()). I think you need to increment `minSdkVersion`

Did you try changing `minSdkVersion` to 26?

Could you propose how a reactive fastexcel API could look like?

I suppose this line needs some tweaking: https://github.com/dhatim/fastexcel/blob/ee98567d289f4e5d12a9506f757ed2fc367c53c6/fastexcel-writer/src/main/java/org/dhatim/fastexcel/Worksheet.java#L431 @ochedru What does this formula actually do? Why exactly those numbers (7,10,256)?

This may be of some assistance: https://github.com/apache/poi/blob/9f07780bac1b86bd65be33857fc33d7fa50f0072/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSheet.java#L553 Looks fairly complex in Apache POI...