ryley-o
ryley-o
Add new minter - Dutch Auction with Refund. terms: - sellout price: price at which an auction sells out, if above the auction base price - auction base price: settling...
Adds CI coverage via CircleCI + Coveralls integrations. Closes #245 Per solidity-coverage docs [here](https://github.com/sc-forks/solidity-coverage/blob/master/docs/faq.md#continuous-integration), Coveralls is the preferred coverage service (over something like codecov) due to its branch coverage reporting...
Per solidity-coverage docs [here](https://github.com/sc-forks/solidity-coverage/blob/master/docs/faq.md#continuous-integration), recommend using Coveralls for this. It is free for open-source repos.
This would benefit this repo be defining things beyond the basic [Solidity style guide](https://docs.soliditylang.org/en/latest/style-guide.html), such as best practices around variable naming, defining events in interfaces, etc.
We currently use Mocha's `beforeEach` hook in our testing suite, but we would achieve a faster testing run time if we were to refactor and use [Hardhat fixtures](https://hardhat.org/hardhat-runner/docs/guides/test-contracts#using-fixtures). This would...
We do not currently implement a static analysis tool. We should add a static analysis tool, such as [slither](https://github.com/crytic/slither).
This is currently a watch-item, based on Foundry adoption and/or advantages. Goal: This will improve developer efficiency, code sharing, reliability, and code health as a function of time. No longer...
Issue for further discussion around the point brought up by @mchrupcala [here](https://github.com/ArtBlocks/artblocks-contracts/pull/236#discussion_r945977536) Basically, is there any desire to standardize the internal representations of percentage vs. BPS? Likely, all percentages would...
Idea from @sarahrossien - adding a start time to the next iteration of our fixed price minters would eliminate the need for artists to send a tx to unpause their...
Artist scripts could be compressed on-chain via something like: - Artist uploads compressed script - compressed script is saved to on-chain storage - Read/getter functions on core contract: - load...