Robert Helgesson
Robert Helgesson
@jwiegley Is it nix-darwin that takes `~/Applications` or something else? I don't know macOS so I assumed that `~/Applications` is a pre-existing directory for all users. I guess that assumption...
I've disabled the feature in the above commit until we've come to an agreement with nix-darwin 🙂
I think https://github.com/nix-community/home-manager/pull/3339 is a relevant PR.
Thanks! Merged to master now. Note, I changed "disable" to "enable" to avoid the negative logic. So the options are now `enableUpdateCheck` and `enableExtensionUpdateCheck`.
Thanks! Fixed a few minor issues and merged to master now. I think some of the code could benefit by having more let bindings to make it a bit more...
Indeed, this is a very nice feature and @kira-bruneau did a great job implementing it! So, I hope my comment above does not seem too negative, it was meant purely...
@kira-bruneau No need for a separate file, I think. It seems to me the thing that would help readability the most in this case is "naming things". For example, instead...
Thanks for the contribution! I've added a few comment 🙂
Thanks! Looks good in general, I just added a few comments. Additionally, please squash/split the commits so that there are two independent commits with the two added features. Something like...
Thanks! I squashed and merged to master now. Note, I decided to rename the `notify` option to `enableNotifications` to make it more clear.