Robert Helgesson

Results 205 comments of Robert Helgesson

Thanks! Merged to master now 🙂 I definitely agree that additional improvements should go through master first.

Thanks for the contribution! I've added a few comments.

Thanks! Merged to master now 🙂

Thanks for the contribution, just added a minor comment.

Thanks! Merged to master now 🙂

Thanks for the contribution! I've added a bunch of, hopefully, useful comments. Note, to actually include the module you need to add it to the `modules/modules.nix` file.

Thanks for the contribution! I've added a few comments.

Must be related to https://github.com/nix-community/home-manager/pull/4644. Perhaps @amarshall has an idea how to avoid this issue? Ideally the checker should not attempt to check external files, there is no guarantee they'll...

Thanks for the contribution! I've added a few comments. Also, it would be good to have an simple test to verify that the generated configuration file is as expected.

Yep, feel free to open a PR with that. Please remove the unnecessary `lib.mdDoc` calls, and separate the option definitions by empty lines.