Ryan Bonte

CSS specificity

17

All generated classes have the same specificity, but that complicates extending generic styles with custom styles for a specific theme. Example: ``` // Button.jsx import React from 'react'; import classNames...

Add possibility to mount directly into shadowRoot

3

Instead of creating a `span` and mounting the React component in there, we could also just mount directly into the `shadowRoot`. According to this [comment](https://github.com/spring-media/react-shadow-dom-retarget-events/pull/12#issue-253607855) the event system of the...

props-json security tip

1

Fixes #9.

Check for falsey strings

1

Fixes #10.

Fix IE11 / Edge error

1

These browsers don't use Shadow DOM mode anyway, so no retargeting needed.

props-json potential security risk?

2

Perhaps point users towards https://github.com/yahoo/serialize-javascript just to be careful?

Does not work with uploaded PDF

2

When using an uploaded PDF converted to for example base64 the rendering of the PDF fails. Loading that very same PDF via a URL works fine. I am using this...

getPageText crashes on larger PDFs

15

`getPageText()` crashes with a `RuntimeError: memory access out of bounds` exception on PDFs larger than around 20 pages. This happens in the browser / WebWorker and Node.js. On Node.js it...

isContinuation is incorrect for results spanning more than 2 lines when using searchPageText

2

`isContinuation` correctly is set to `true` for the first rectangle when a result spans 2 lines. However, when a result spans 3 lines, one would expect the second rectangle to...