Ryan Zhou

Results 7 comments of Ryan Zhou

If this hasn't been fixed yet, I'd like to try fixing it. Is the relevant code in`src/filters/std/slice.rs`?

Yeah, it looks like reverse indexing should be handled. Why should the test fail if reverse indexing is handled?

@epage It looks like this test: ```rust assert_eq!(v!(""), filters!(Slice, v!("foobar"), v!(1), v!(0))); ``` is failing, which I think is expected behavior since the slice length is 0. The code in...

From the Ruby conformance tests, it looks like a slice of length 0 should just return an empty string/array. I changed the condition above to `length < 0` and the...

I'd like to try and tackle this one too, if @veatnik isn't working on it anymore.

I'd like to try and tackle this one if it hasn't been done yet! The tests seem quite long though...

Ok great, I'll slowly work on this then.