clean-code-javascript

clean-code-javascript copied to clipboard

Want to translate to Arabic, Japanese, French, etc.?

34

Starting to translate to Korean. Feel free to collaborate. Check it out [here](https://github.com/Hanney-Ryu/clean-code-javascript/blob/master/README-ko.md).

Hanney-Ryu

Avoid conditionals: Favor Composition over Inheritance (Classes)

1

[Avoid conditionals](https://github.com/ryanmcdermott/clean-code-javascript#avoid-conditionals): Favor Composition instead of Classes It's preferred for newcomers to learn about composition first, and Classes as a syntax sugar on top of Prototypal inheritance later. As explained...

benoror

Suggestion

1

It is recommended to put the translated version of the navigation on the top, I read the whole process by the translation plug-in.

ChanWahFung

Turkish Translation

1

Hi @ryanmcdermott, Many thanks for this great document. I have finished translating it into Turkish and will can you please add this it to the translations list if possible? https://github.com/umutphp/clean-code-javascript-tr

umutphp

ESLint

6

Is it possible to make an ESLint configuration that takes into account these good practices? It would be a good idea to be able to evaluate the code and reinforce...

gmarcos87

Change wording and add examples for Liskov Substitution Principle

1

Hello! Love this repo - incredibly useful, and I've bookmarked it for future reference. I'd like to suggest a change to the writeup on the Liskov Substitution Principle. The text...

strunkandwhite

Use default arguments instead of short circuiting or conditionals

2

It's mentioned that _Other "falsy" values than undefined such as '', "", false, null, 0, and NaN, will not be replaced by a default value._ I am doubtful as below...

mdv27

Just a suggestion, but I think the example conflicts a bit with other philosophies espoused in this repo. * `SuperArray`. is not a descriptive name. `DiffableArray` or something like that...

ajcrites

Don't use flags as function parameters

2

Thanks for this wonderful curation of clean coding practices. I don't have so much as an issue but I'm unable to wrap my head around [this](https://github.com/ryanmcdermott/clean-code-javascript#dont-use-flags-as-function-parameters) rule, as to how...

kanalasumant

"Don't write to global functions" section improvement

3

Two things from my side: 1. Is there a reason to use `Set` inside the example function? Considering there's also `Array.prototype.includes`: ```diff Array.prototype.diff = function diff(comparisonArray) { - const hash...

feimosi