clean-code-javascript

clean-code-javascript copied to clipboard

Great guide! My critique of a few of the principles

6

Not-so-well put together brain dump follows. Note that in some parts the tone may appear a bit harsh, but I stand by my criticism and believe that some of the...

benny-medflyt

Hi, thank for the great docs, I notice there's an absence of link in `Formatting` section (see [HERE](https://github.com/ryanmcdermott/clean-code-javascript/blob/master/README.md#L2090)).

atefBB

The Moment library is deprecated in favor of Luxon. Replace example based on moment with equivalent luxon code. [ref](https://momentjs.com/docs/#/-project-status/)

hughescr

Above the example, we `setWidth(4)`. For `Square`, it should get 16.

yuetong3yu

French translation is broken

2

Hi @ryanmcdermott, I replaced broken link with up-to-date French translation.

eugene-augier

hi Could I translate this to Persian language? [i want to trans](https://github.com/imokech/clean-code-javascript)

imokech

Bumps [puma](https://github.com/puma/puma) from 5.5.1 to 5.6.4.

1

Bumps [puma](https://github.com/puma/puma) from 5.5.1 to 5.6.4. Release notes Sourced from puma's releases. 5.6.4 Security Close several HTTP Request Smuggling exploits (CVE-2022-24790) The 5.6.3 release was a mistake (released the wrong...

DaviidFr

Set default objects with Object.assign

5

No, you should use object spread syntax here. ``` config = { title: "Foo", body: "Bar", buttonText: "Baz", cancellable: true ...config}; ```

rtm

What about Magic strings?

13

Do you think that can be good to include something about magic strings? **Bad:** ```javascript let posts = getPostsFromCategory('sports'); ``` **Good**: ```javascript const categories = { sports: 'sports', economy: 'economy'...

CKGrafico

Hello. This is a useful resource. When reading the section on the Interface Segregation Principle it occurred to me that the code section could give a stronger and clearer example....

cpressey