Ryan Greenberg

I don't really know enough about type systems to discuss intelligently what should be inferred for unreachable code—`nothing` seems reasonable—but I do think it would make the typechecker more useful...

Past Ján and Ryan did not really help us out here. From #206: > Based on a discussion with @jjergus in #190, this PR eliminates autofixes for unused variables in...

@klingerf and @sprsquish, I know this library isn't something that you work on day-to-day, but if you have a moment I'd love to hear your take on this issue.

**Current options (from the gem docs):** `:exception_classes`: Which exceptions to catch and retry when sending a request. Defaults to [IOError, Thrift::Exception, Thrift::ApplicationException, Thrift::TransportException, NoServersAvailable] `exception_class_overrides`: For specifying children of classes...

@sprsquish good point--providing something other than a list of classes as `exception_classes` is weird. Let me first try pursuing this from another angle to see if the Thrift project is...

See https://issues.apache.org/jira/browse/THRIFT-2403.

The problem here is with the exception wrapping, which assumes the first field in the exception constructor is the message (it's actually the type). From `thrift` exceptions.rb: ``` class ApplicationException...

https://www.php.net/manual/en/function.preg-quote.php: > preg_quote() takes str and puts a backslash in front of every character that is part of the regular expression syntax. This is useful if you have a run-time...

@andyfeller Thanks for the question and apologies for the delayed follow-up—I must have missed the notification. > Would you say the bug here is that gh pr merge didn't error...

I closed #10202 as a duplicate of this issue. One detail there that I'd add here: I can get into this state readily by using ctrl + g to edit...