Riccardo Vianello

Results 39 comments of Riccardo Vianello

Hi @mikolajfeliks, many thanks for the PR! I was applying some similar changes to `mol_to_svg` in a local branch (that apparently I forgot to push - it doesn't matter), but...

thanks a lot for taking the time to troubleshoot the error and create a PR @yangjinhao1234

I tried running different subsets/combinations of the involved tests, but I'm still quite far from understanding the the problem. As far as I can tell, in my build environment `$...

Because the error on which tests are executed, and in which order, I'm unsure pytest can be the sole responsible. As you correctly pointed out `$ pytest UnitTestLogging.py Chem/UnitTestChemAtom.py` is...

@df7cb sorry, but just to help me learn more about postgres, would you please briefly elaborate about why these changes are necessary/recommended, or what you more specifically meant with "stricter"?...

ah, maybe I got it now.. PG_DETOAST_DATUM returns a struct varlena *, it was ok as long as DatumGetPointer was a macro just casting to a different pointer type, but...

I created a small PR against your branch to apply the same fix in a couple additional places. If those changes look ok to you, I think it would make...

@df7cb it was this one here https://github.com/df7cb/rdkit/pull/1 (you may have now implemented the same changes already, I didn't check).

@df7cb @greglandrum sorry, the conversation around this PR was a bit intermittent and I noticed the related warnings again today. I think the PR was ready to merge, or were...