Richard van Heest

Results 8 comments of Richard van Heest

Thanks for the quick response (as always!). I now see what my confusion was: in `PayloadVerifier` I mainly looked at line 105-109 and glanced over 102-103. That one does the...

@jscancella _Not sure if I can ask this here or if I should make a new issue for this. However, since you're touching the class I wanted to ask about...

@jscancella I understand why you made these classes final. We defined a another kind of validness (called 'virtually valid'), which is basically the same as 'valid', but with some different...

@jscancella, as I mentioned in another place to you, we use the concept of Bags, BagIt, etc. as one of our storage formats. Indeed we also use it for transferring...

@acdha From reasoning through the code this looks fine. But I wasn't able to test it with the code change in my own project, since I can't find a way...

Hi @jscancella I'm aware of the inactivity of LoC on this library since you left. For this reason, we at @DANS-KNAW started a [friendly fork](https://github.com/DANS-KNAW/bagit-java) for this library last year...

@jscancella shouldn't it also do something with `MessageFormatter.format`. I now see that in other places in that class as well...

@jscancella I'm not really sure what you mean by > If you merge this PR in I would recommend extensive testing to ensure any assumptions made during the original design...