Rupert Nash
Rupert Nash
I have just hit B006 for a library where we enforce type annotations via mypy. I have: ```python def whatever(self, optional_map: Mapping[str, str] = {}) -> None: pass ``` In...
Hi Cooper- thanks for the quick response. I understand (and support) the logic of the check. Mypy performs static type checking on the program. If my function `whatever` above were...
1. The benefit here is that I only have to pass the optional mapping type when I need to. I agree this is tiny for this example, but with multiple...
OK - I've just had a look and the basic thing is very easy. ``` diff --git a/bugbear.py b/bugbear.py index d39ff01..733bc2f 100644 --- a/bugbear.py +++ b/bugbear.py @@ -345,8 +345,29 @@...
Note that when this is resolved, we can remove the exclusion from `conformance-test.sh`.
See also my issue #75 and PR #77 It may be possible to address both of these in the same code since both are G4.
Ah - sorry I hadn't seen that - thanks for flagging for me. The choice of name ("reset") doesn't really reflect the way I was thinking about it (just encoding...
I think the `resetting_counter` has an off-by-one error. If there has been 1 reset/overflow of the least significant word, and the sensor LSW is zero, then the result should be...
Can anyone with an inverter that's been running long enough please confirm this by checking against the SolaX cloud view?
Great- thanks for checking. I’ve made a PR (#77) which includes this feature. Feel free to separate that out and merge separately (if you have the permission lol)