Rui Craveiro

Results 19 comments of Rui Craveiro

Hi @mraleph, can you find some time to look at this? It's actually a relatively simple change and the greatest number of lines added were to set up the new...

Hi, I am having the same behaviour on the following Samsung Galaxy devices: - S23 SM-S911B/DS - A23 SM-A236B/DSN - XCover Pro SM-G715FN/DS On all of them, when cycling through...

Hi @hellohuanlin, I have improved camera_avfoundation's implementation based on your comments. Instead of adding a new commit, I forced pushed a squash commit of those changes and another commit on...

> LGTM on iOS. But please get stamps from other platforms too. Thanks!!

Hi @camsim99 :-) Oh dear, I forgot to push them to GH... oopsie.

Just submitted https://github.com/flutter/packages/pull/7548 for only the platform interface.

Hi reviewers, after feedback from @stuartmorgan, I am resubmitting this with a revised set of enum options. They were made more abstract. So, now VideoStabilizationMode no longer has off, on,...

> From triage: @ruicraveiro is this still something you are planning to come back to? I would prefer to get it approved as it is, but yes my intention is...

> > I would prefer to get it approved as it is > > The current version conflates `Exception`s and `Error`s as discussed in the long comment thread above, so...