Cody Caughlan

Thanks for the feedback. Yes it does look like the library is not auto-inserting the `DetailType`. I pulled up some of my own code which uses taxes and it looks...

I am using a numeric reference to the `tax_rate_ref` (which is not clear from your right hand value of `code`). So to clarify that code from my end: ```ruby def...

Thanks @Zajn > It does look like the Faraday upgrade will require at least Ruby 2.6. CI failed for 2.5. Ugh. I'm on Ruby 2.5.8 for the foreseeable future for...

Possibly related to #393 - it looks like `net/http` is not thread-safe which might be the crux of this https://stackoverflow.com/questions/3063088/is-rubys-nethttp-threadsafe

I think we're going to have to switch to a threadsafe HTTP client like * `rest-client` : https://github.com/rest-client/rest-client * `httpclient` : https://github.com/nahi/httpclient

Although I am quite surprised that no one has encountered this issue before. Put another way: I find it hard to believe you're the first Puma/Sidekiq user to use this...

@drewish Yes the `389-oauth2` branch does use Faraday but thats really indirectly by virtue of the dependent `oauth2` gem using it. This gem does not directly use `net/http`, its used...

@greycampbell oof, thats no bueno. im still in a single-threaded / process based environment, so I wouldn't see this. hopefully others that can chime in and provide advice/ideas/support.

Thanks for the PR. The specs are failing. We'll need a green build for a merge. Thanks again!

If you are referring to asking QBO to send an invoice email with the attachment please refer to this: https://github.com/ruckus/quickbooks-ruby#emailing-invoices