Irfan Ahmed comments

Results 13 comments of


                                            Irfan Ahmed

git flow start/finish reports unstaged changes when there are none to commit or push

git reset --hard origin/master can save your life!

Code Triage shouldn't email me requests for private method documentation

I agree. I received a documentation issue for a :nodoc: module. Either they are private method or mostly the module is for internal class. If we can make it improved...

Github api reauth token problem

Let me check.

Rails 7.1: query_constraints: causes relation to not be loaded.

This is rather a bug of #foreign_key which I suggest https://github.com/rubyrider/rails/pull/2/files to @iamradioactive as his pull request was trying to fix it in the query constraints. The foreign key supposed...

Fix issue with destroy after RestartParentTransaction and SavepointTransaction rollback

I suggest a fix to your branch, here is the pull request to review: https://github.com/mguan2020/rails/pull/1

Fix issue with destroy after RestartParentTransaction and SavepointTransaction rollback

thanks!

Fix issue with destroy after RestartParentTransaction and SavepointTransaction rollback

@auvipy thank you for your concern dear, but this is totally fine for me, I don't need a credit 👍 I am here as a volunteer purpose only.

Fix issue with destroy after RestartParentTransaction and SavepointTransaction rollback

@mguan2020 i will take a look.

Fix issue with destroy after RestartParentTransaction and SavepointTransaction rollback

@mguan2020 its passing locally. can you try re-running the test or rebase your branch and update your branch to see if the latest build fixes it?

Updating delegated types using delegate type attributes produces orphaned children

What about passing an id of existing purchasable object?