Ruben De Visscher

Results 8 comments of Ruben De Visscher

> \o Hey @rubendv, thanks for the PR! :-) Do you mind adding a test for this? It'd be great to make sure we don't break this again in the...

I added tests @cipherboy. I noticed in the contributing guide it says that PRs should reference issues, would you like me to still create an issue for this PR?

We are also affected by this. We've removed opentelemetry instrumention temporarily as a workaround, but this is not an option for everybody of course.

We fixed it by using the previous version: ``` pip install opentelemetry-distro==0.41b0 opentelemetry-exporter-otlp==1.20.0 ``` After this `opentelemetry-bootstrap --action install` works fine.

Okay, I'll wait for you to fix the default value and then it can be merged. Thanks for the PR!

std::string was already used by the original NaCl C++ API, and I'd like to keep it that way for the low level API. For the high level API std::vector is...

I agree that `std::vector` is a better fit, but that would mean breaking with the NaCl C++ api: (e.g. https://nacl.cr.yp.to/box.html). I suppose we could overload them and implement both for...