Ryan Zoeller comments

Results 47 comments of


                                            Ryan Zoeller

Could we get a release with a bumped version of nix?

Note that nix 0.24.1 is now out. The 0.24 release splits nix into features, so I'd recommend updating to that and enabling just the features you need to improve compile...

fix bugs on android armv7, because `pw.pw_passwd.is_null()`

How are you testing these changes - something like Termux? I'd like to see if I can reproduce this on my end. Thanks!

fix bugs on android armv7, because `pw.pw_passwd.is_null()`

Thanks! Confirmed this reproduces for me. Can you add an entry to the CHANGELOG.md file under the `Fixed` section, squashed into the current commit?

fix bugs on android armv7, because `pw.pw_passwd.is_null()`

@ClarkGuan can you squash the current two commits into a single commit?

Add a `sched_getcpu` wrapper

Thanks! Can you modify the existing test [here](https://github.com/nix-rust/nix/blob/a45e9f8fe8e18be48cd40de941d867581e3c6ac0/test/test_sched.rs) to validate that setting the affinity actually has an effect by calling `sched_getcpu`?

Add a `sched_getcpu` wrapper

@jonas-schievink can you squash the current changes into a single commit? Otherwise this looks great.

Upgrade nix to 0.24, limit features

To avoid breaking https://github.com/rust-embedded/linux-embedded-hal, I think we'll need to make this change to all of the embedded repos around the same time...

Make memfd available on Android

@AndrewScull can you add a section to CHANGELOG.md, as part of this commit?

Make memfd available on Android

@AndrewScull can you rebase to fix the CHANGELOG.md conflict?

`SockaddrStorage::as_sockaddr_in` incorrectly returns None sometime

@asomers do you have a Mac that you can try the reproducing example on? I tried following the logic by hand (the Linux libc definitions differ enough to make it...