Rudi Theunissen

Hi @TysonAndre :wave: My long-term intention has been to _not_ merge this extension into php-src. I would like to see it become available as a default extension at the distribution...

> Do you mean OS distribution level (Windows, Ubuntu, CentOS, HomeBrew for mac, etc.?) >> He meant distribution with PHP core (on all platforms where PHP is available) Whichever is...

I'm going to close this discussion because I would rather start from scratch with a much smaller footprint and a focus on persistence.

Hi everyone, I am happy to see this discussion and I thank you all for taking part. My reservation to merge ds into core has always been because I wanted...

My position currently is that I think we should start from scratch and borrow whatever is good from php-ds that we want to keep to implement something natively in core....

Currently the equals method won't be called (assumed false) if the value is not an instance of the same class.

~You should always be able to pass anything to an equality check, but the internal implementation does the instanceof check for you so that you can focus on what's important....

There is some bad design here because the equals method is not meant to be called directly, which is crazy. Thanks for bringing this to my attention.

When checking equality, ext-ds takes a shortcut to avoid invoking a callback unnecessarily. But any value should be a valid argument so the docs are wrong. A good solution here...

That is correct. There should then be no typehint at all and the implementation should check that the object is of the same class using `instanceof`. If it is library...