Robert Spencer
Robert Spencer
I license past and future contributions under the triple MIT OR Apache-2.0 OR Zlib license, allowing licensees to choose any one at their option.
I'd say the biggest loss was actually the newtypes. I recently ran into a (stupid) error which could have been caught by the compiler telling me I was trying to...
It introduces a bit of boilerplate and destructuring code throughout, but I would personally think it is worth it (and, as you say, no worse than the web code).
According to the README, Windows doesn't support DIM either, yet that is included in colorama. I think this is reasonable to ask to include this, just with a silent fail...
I'm interested in working on this, but am new to the codebase. Would it make sense to record the fields as "events" or should a separate `Tree` leaf node be...
If we have the fields on the same line as the span, would that be their values at span entry?
I'd also perhaps suggest (after playing around a little) that a "record update" tree node might be useful. Selfishly for my project I need to know when `Span::record` is called....
> I'm thinking we would have both on the same line, similar to how events currently work. Sounds good. I'm asking if we should report the field values when the...
I think I'm being overly pedantic. I'll look at implementing a `Layer`.
Great, thanks. So if I understand the plan correctly I am going to implement a new [`Layer`](https://docs.rs/tracing-subscriber/latest/tracing_subscriber/layer/trait.Layer.html) that people would use by ```rust tracing_forest::worker_task() .build_on(|subscriber| subscriber.with(SpanFieldLayer)) .on(async { // ......