Robert Sammelson
Robert Sammelson
@Dnouv can you fix the linting issue?
I really like this look!
I was also unable to run it on CentOS 7
I'm not sure what caused that change, let me fix it.
@tgross35 It should be fixed now.
@tgross35 I don't understand why the tests are failing.
The issue is cause by the fact that temporary files are created with 600 permissions. In `set_art`: https://github.com/beetbox/beets/blob/6989bce6cab134e937acd21720b4a165f916a60b/beets/library.py#L1340-L1343 So if `copy` is false, the temporary files are copied over, including...
From the python documentation (https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp) > Creates a temporary file in the most secure manner possible. There are no race conditions in the file’s creation, assuming that the platform properly...
`mkstemp` does not have a way to change the permissions as far as I can tell, so I'm guessing that the easiest way to do it is to use copy...
Yeah, the second one is why I couldn't figure out a good way to implement it. It would probably be the best to just reset the permissions, but I haven't...