Rafael da Fonseca comments

Results 46 comments of


                                            Rafael da Fonseca

ETCD integration package is broken if any other module in the project uses updated opentelemetry

Related issues: https://github.com/open-telemetry/opentelemetry-go/issues/2577 https://github.com/etcd-io/etcd/issues/13664

Storage backends for adaptive sampling

Is it really supported? When I try to start jaeger-collector (tested with 1.55.0 and 1.56.0) with `SAMPLING_STORAGE_TYPE=elasticsearch` I get the following: `{"level":"fatal","ts":1712826901.3422914,"caller":"collector/main.go:92","msg":"Failed to create sampling store factory","error":"storage factory of type...

Allow configuring nginx worker reload behaviour, to prevent multiple concurrent worker reloads which can lead to high resource usage and OOMKill

Hi @rikatz, thanks for reviewing :) Regarding concurrency and using a single variable, i don't think this would be a problem in the way things are designed overall, but let's...

Allow configuring nginx worker reload behaviour, to prevent multiple concurrent worker reloads which can lead to high resource usage and OOMKill

Any luck getting a chance to look at this @tao12345666333 ?

Allow configuring nginx worker reload behaviour, to prevent multiple concurrent worker reloads which can lead to high resource usage and OOMKill

> Sorry for the long delay. Let me take a look Any news @tao12345666333 ? I'm waiting to get this merged so I can move off my fork and upgrade...

Allow configuring nginx worker reload behaviour, to prevent multiple concurrent worker reloads which can lead to high resource usage and OOMKill

> BTW this PR need rebase rebased @tao12345666333 :) looks like pull-ingress-nginx-codegen job is failing, but it's unrelated to this PR

Allow configuring nginx worker reload behaviour, to prevent multiple concurrent worker reloads which can lead to high resource usage and OOMKill

> @rsafonseca as we have bumped a bunch of libraries, please rebase over main to be sure codegen job will run using golang v1.22 and the latest k8s versions during...

Allow configuring nginx worker reload behaviour, to prevent multiple concurrent worker reloads which can lead to high resource usage and OOMKill

Looks good @tao12345666333 , thanks for fixing this in main :)

Specifying notification Provider's namespace in an alert

I've opened a PR that solves this issue and a couple others :)

Add shareable providers

@stefanprodan would you be able to take a look? 👀 Thanks! :D