Rahul Butani

Results 66 comments of Rahul Butani

@vi does the macro described in #37 work for your use case? The example on that PR uses a slightly more general delegated impl but it's possible to restrict it...

> though I obviously need to change `&S` to `&dyn Shout` or `& (dyn Shout + Send + Sync oh whoops, good catch! > But when I try to extend...

Unfortunately I don't think calling `canonicalize` fixes the process substitution case; i.e. ```bash git diff --no-index $(realpath

@dandavison If I don't find a better way though, is ^ worth implementing/merging? Is the temp file solution worth writing (seems like the kind of thing that may be better...

> Yes #543 made me realize that there is benefit in using `git diff` for this -- I do think it makes sense to stick with it. Do you know...

I think it's ultimately a question of which behavior is more surprising when asked to diff two process substitutions: slightly different diff output or one of the streams being written...

> The Rust compiler doesn't display this specific information either. Sorry, I'm not sure I follow; I think `rustc` _does_ show the line/col for the span attached to errors/warnings: ---...

Hi! I'm not a maintainer of this repo but I did write #85 and I'd love to know more about the changes you made to support cross compilation and/or to...

Thanks! Some misc notes: - I mentioned target triples / Bazel platforms because #85 tries to [add the right constraints](https://github.com/grailbio/bazel-toolchain/pull/85/files#diff-3e6e7a1e5f089185cbada0c1dbb794097252ac0daa587c787219ba795cc74ed6R1-R346) to each toolchain's `target_compatible_with` from the target triple itself instead...

> That's neat, and I agree it's somewhat excessive. I think it's unlikely that a toolchain for some untested platform will work without tweaking, so I'd rather prioritize making it...