Rahul Rangith
Rahul Rangith
If this proposal sounds good, I can put up a PR to implement this
/assign @jackfrancis @feiskyer I presented this at the SIG Autoscaling meeting and they suggested I reach out to you. Can I please get a review?
closing in favour of https://github.com/kubernetes/autoscaler/pull/6863
/remove-lifecycle stale
> just a question as i'm reviewing, is there any relationship or interaction between this flag and the balance-similar-node-groups flag? (eg does the latter need to be enabled or anything...
> I'm afraid I'm a bit lost here. Why should `Expander` be the source of truth for computing similar node groups, don't we have `NodeGroupSetProcessor` for that? > > Expander...
> > With the gRPC expander for example, you can have any custom logic you want. So if for example I want to filter out any nodegroups that have the...
/reopen @x13n as I said in https://github.com/kubernetes/autoscaler/issues/6940#issuecomment-2631321846 > We are currently using https://github.com/kubernetes/autoscaler/pull/6926 and https://github.com/kubernetes/autoscaler/pull/6941 in our fork and it is working perfectly fine, but I'd be interested in seeing...
hi @linhua11 i opened https://github.com/kubernetes/autoscaler/pull/7383 which should fix this issue