rr0gi

Results 14 comments of rr0gi

having opam environment set up would allow to not duplicate build commands in yml, but invoke same wrapper as developers are using (e.g. make)

fixed in https://github.com/ClickHouse/clickhouse-cpp/pull/205 ?

fixed in https://github.com/ClickHouse/clickhouse-cpp/pull/205 ?

``` diff --git a/src/lib/Dune.ml b/src/lib/Dune.ml index e635dd2..3247bc5 100644 --- a/src/lib/Dune.ml +++ b/src/lib/Dune.ml @@ -36,15 +36,15 @@ let extract_strings sexp_list = let extract_names entry = let public_names = match find_list ["public_names";...

afaics simply adding `const` doesn't work, I figure it is because of refcounted : ``` // Buckets form contigous array. We keep this array refcounted, so that // we can...

rebased to master and removed cast

I think it should also check if new_size is bigger than current allocated (smaller than current size is ok to allow to shrink unused buckets, but smaller than number of...

(btw thanks to the added comment I noticed that capacity is `actual_size - allocated`, which is somewhat unexpected, in other libraries I used before capacity is actual_size and then the...