Ron Petrusha comments

Results 12 comments of


                                            Ron Petrusha

protected members from sealed classes should not be generated

Yes, that's correct, @joelmartinez.

Some members are somehow missing the F# or VB signature

There's also a member missing the VB signature (though it's not an EII): https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System.Configuration/AppSettingsReader.xml#L153

Multiple fields are marked “This is the default behavior”: Default, NotSet

Thanks for the feedback, @binki. We'll investigate and update the documentation accordingly.

ConsoleSection class is not defined in the code

Thanks for pointing this out, @jack147527. The source code is incomplete in many instances here, unfortunately. We'll schedule some time to work on presenting compilable source in an uncoming sprint....

Example code has runtime error

Thanks for pointing this out, @ackerman76. The ConditionalWeakTable.TryGetValue method documents the ArgumentNullException, but this example nevertheless passes a null value to the method. It also does a very poor job...

Incorrect examples of ...OutOfRangeException

Thanks for pointing this out, @NextTurn. I'll address it in an upcoming sprint.

Add code sample

This is a request for an example, I'm adding it to the backlog, as well as to the community contributor's project.

Incorrect example in CheckSignature(X509Certificate2Collection, Boolean)

Thanks for pointing out that the examples call the wrong overload, @Crunchie. We've removed the examples from the CheckSignature(X509Certificate2Collection,Boolean) documentation. We've also added this issue to our backlog the community...

Remove or replace catch blocks that handle Exception

Thanks for opening this issue, @jinek. This is a problem throughout the documentation set, so I've added it to the [.NET Community Contributors project.](https://github.com/dotnet/docs/projects/35). So if anyone would like to...

Remove or replace catch blocks that handle Exception

Thank you so much for your offer to help with addressing exception handling in the doc set, @jinek! I'll respond by tomorrow with a detailed plan for reviewing the examples...