Patrick Roy

Results 107 comments of Patrick Roy

To summary what we just talked about off-line, I was imagining a very simple top-down parser like this (in a mix of rust and pseudocode since I am not familiar...

> I am surprised and a little concerned that there aren't existing libraries that allow bit/bit-field handling. If we are convinced that there are no publically available alternatives to an...

We've discussed this with the team today and decided against adding shellcheck to our CI. This is mainly due to having bad experiences with its false-positive rates, that are similar...

We have tests for restoring snapshots across different x86_64 CPU models in https://github.com/firecracker-microvm/firecracker/blob/main/.buildkite/pipeline_cross.py, however we do not specifically exercise any TSC related functionality. I'm marking this issue as Parked, as...

Moved to https://github.com/firecracker-microvm/versionize/issues/50

Hi @thunderZH963, if you are still experiencing this issue, could you please provide us with a minimal reproducible example? E.g. not just the tool used, but also the exact test...

> Hi! > > I do like the proposal! However, I am concerned about the possibility of a breaking change since I do expect that users of the `rebase-snap` tool...

Hey @CompuIves, we have implemented this functionality in #4301 based on your proposal. I am thus closing this PR. Thank you again for your contribution!

Firecracker is no longer using versionize, having replace it with serde in https://github.com/firecracker-microvm/firecracker/pull/4230. Closing this issue as no longer applicable

For now, we are not planning to do this, as we do not see benefits from this as a stand-alone change. Should a change like this become necessary for any...