node-epimetheus
node-epimetheus copied to clipboard
roylines
node middleware to automatically instrument node applications for consumption by prometheus
Builds on the work done by @Y-Lyn-10 in roylines/node-epimetheus#52 to run the tests with Hapi 18 to ensure support.
### Overview If you are not aware yet, Hapi v17 is making the transition from callbacks to `async`/`await`, as well as deprecating some other rarely used functionality. This is a...
Here's a proposal for HAPI 17.x support for Epimetheus. Since this version is a major overhaul of HAPI, please be advised that it is not backwards compatible.
Refers #43 Hey. I just noticed that there are already 2 PRs for Hapi v17 Support, but I have already spent half of my day to make these changes (lessons...
It seems like the metrics exposed right now do not adhere to best-practice. I'd like to discuss this before proposing any changes :)
To avoid exposing the metrics to anyone accessing the site, it would be nice to be able to instrument the server without adding the /metrics route to it.
From time to time we see this error in our logs: ``` Debug: internal, implementation, error TypeError: Cannot read property 'statusCode' of null at server.on (..../node_modules/epimetheus/lib/hapi.js:23:74) ``` As this happens...
This commit adds hapi v17 support and changes the .instrument() method for hapi to be async Additionally some codestyle fixes included
