node-epimetheus icon indicating copy to clipboard operation
node-epimetheus copied to clipboard

Added support for Hapi v17

Open Y-LyN-10 opened this issue 7 years ago • 1 comments

Refers #43

Hey. I just noticed that there are already 2 PRs for Hapi v17 Support, but I have already spent half of my day to make these changes (lessons learned).

Although, I believe that this PR has it's merit as it's absolutely up-to-date, so maybe you could take a look, please?

Here is a list of changes:

  • [x] Updated the hapi plugin to work with async/await
  • [x] Updated the tests accordingly (to the async server)
  • [x] Updated the example and manually verified that it runs on Docker with no issues with the latest changes
  • [x] Updated vulnerable npm dependencies, so "npm audit" now returns "found 0 vulnerabilities"
  • [x] I've been trying to follow the existing code style (i.e no semicolons), but following hapi.js code conventions for the API usage)
  • [x] Documentation updates

If you consider this PR, I pledge to follow-up on any feedback regarding additional changes in a timely manner :pray:

Y-LyN-10 avatar Oct 08 '18 17:10 Y-LyN-10

Any chance this is going to get merged? Hopefully the third times the charm

jimgreenejr avatar Oct 23 '18 17:10 jimgreenejr