Andrii Roiko

icon location Lviv,Ukraine

Results 5 comments of Andrii Roiko

Link is not working

Thanks for the project :)

Small fixes

Також не дуже розумію чому падає CI тест, щось потрібно виправити у моїх змінах?

Import: No support of AWS Athena (Trino) DDLs

@jochenchrist Sure! Just created a feature request in their repo: https://github.com/xnuinside/simple-ddl-parser/issues/272

Type hinting/annotation style

@jochenchrist sure, would love to work on this but can't guarantee a quick work done. We probably ought to exclude some of the mypy checks... will see and discuss in...

import sql (postgres ddl) into datacontract.yml: numeric --> variant

I think a lot of stuff just not yet implemented. As of `numeric` type, it should be pretty easy to fix: https://github.com/roykoand/datacontract-cli/blob/b56656a1d99fbfc7fb8a26da3df666a5a00ac438/datacontract/imports/sql_importer.py#L51-L82 You would need to add `numeric` into this...